Conversation
tkajtoch
added
skip-changelog
weronikaolejniczak
approved these changes
Nov 14, 2025
Contributor
weronikaolejniczak
left a comment
weronikaolejniczak
left a comment
There was a problem hiding this comment.
LGTM! 🟢 Still can't with the dependency typo 😂 exits 0.
mgadewoll
reviewed
Nov 14, 2025
packages/eui-theme-borealis/src/variables/colors/_semantic_colors.scss
Outdated
Show resolved
Hide resolved
Collaborator
💚 Build SucceededHistory
cc @tkajtoch |
Collaborator
💚 Build Succeeded
cc @tkajtoch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes linting errors related to code style in
eui-theme-borealis, re-enables linting during release, and fixes a typo inpackages/eui-theme-borealis/package.json, causing yarn to not correctly detecteui-theme-commonas a dependency ofeui-theme-borealis.Why are we making this change?
Related to https://github.com/elastic/eui-private/issues/448. It's not a direct dependency, though.
Impact to users
Build chain only; no impact to users
QA
yarn workspaces foreach --all --parallel --topological-dev --exclude @elastic/eui-website --exclude @elastic/eui-monorepo --exclude @elastic/eui-docgen run lintlocally and confirm it exists with status0. It will report some warnings, but that's expected.